Skip to content

Commit

Permalink
Bump android version to 34
Browse files Browse the repository at this point in the history
  • Loading branch information
m-kuhn authored and github-actions[bot] committed Aug 11, 2024
1 parent 3cddf61 commit 23e5c72
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .docker/android_dev/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ shopt -s extglob
mkdir /android-sdk/cmdline-tools/latest
mv /android-sdk/cmdline-tools/!(latest) /android-sdk/cmdline-tools/latest
yes | /android-sdk/cmdline-tools/latest/bin/sdkmanager --licenses
/android-sdk/cmdline-tools/latest/bin/sdkmanager "platforms;android-33" "build-tools;29.0.2" "platform-tools" "tools"
/android-sdk/cmdline-tools/latest/bin/sdkmanager "platforms;android-34" "build-tools;34.0.0" "platform-tools" "tools"
END_OF_SCRIPT

ENV ANDROID_NDK_HOME /android-ndk-r25c
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:
echo "ANDROID_NDK=/usr/local/lib/android/sdk/ndk/25.2.9519653" >> $GITHUB_ENV
echo "ANDROID_NDK_HOME=/usr/local/lib/android/sdk/ndk/25.2.9519653" >> $GITHUB_ENV
echo "ANDROID_NDK_ROOT=/usr/local/lib/android/sdk/ndk/25.2.9519653" >> $GITHUB_ENV
echo "ANDROID_BUILD_TOOLS_VERSION=33.0.0" >> $GITHUB_ENV
echo "ANDROID_BUILD_TOOLS_VERSION=34.0.0" >> $GITHUB_ENV
echo "ndk.dir=/usr/local/lib/android/sdk/ndk/25.2.9519653" >> local.properties
ALL_FILES_ACCESS=${{ matrix.all_files_access }} ./scripts/ci/env_gh.sh
Expand Down
4 changes: 2 additions & 2 deletions cmake/Platform.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ elseif(VCPKG_TARGET_TRIPLET STREQUAL "x86-android")
endif()

if(ANDROID_ABI)
set(ANDROID_BUILD_TOOLS_VERSION "33.0.0" CACHE STRING "Android build-tools version")
set(ANDROID_TARGET_PLATFORM 33 CACHE INT "Target Android platform SDK version")
set(ANDROID_BUILD_TOOLS_VERSION "34.0.0" CACHE STRING "Android build-tools version")
set(ANDROID_TARGET_PLATFORM 34 CACHE INT "Target Android platform SDK version")
set(ANDROID_PLATFORM 21 CACHE INT "Minimum Android platform SDK version")
set(ANDROID_PLATFORM_INT 21 CACHE INT "Minimum Android platform SDK version") # Used in build.gradle.in
set(ANDROID_CPP_FEATURES "rtti exceptions")
Expand Down

0 comments on commit 23e5c72

Please sign in to comment.