Skip to content

Commit

Permalink
Bump minimum Android version to 23 (Android 6)
Browse files Browse the repository at this point in the history
Minimum requirement imposed by Qt
  • Loading branch information
mohsenD98 authored and nirvn committed Aug 25, 2024
1 parent 70a9a51 commit a73b01d
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,11 @@ jobs:
run: |
NDK_VERSION=26.3.11579264
echo "JAVA_HOME=${JAVA_HOME_17_X64}" >> $GITHUB_ENV
echo "ANDROID_BUILD_TOOLS_VERSION=34.0.0" >> $GITHUB_ENV
echo "ANDROID_NDK_VERSION=${NDK_VERSION}" >> $GITHUB_ENV
echo "ANDROID_NDK=/usr/local/lib/android/sdk/ndk/${NDK_VERSION}" >> $GITHUB_ENV
echo "ANDROID_NDK_HOME=/usr/local/lib/android/sdk/ndk/${NDK_VERSION}" >> $GITHUB_ENV
echo "ANDROID_NDK_ROOT=/usr/local/lib/android/sdk/ndk/${NDK_VERSION}" >> $GITHUB_ENV
echo "ANDROID_BUILD_TOOLS_VERSION=34.0.0" >> $GITHUB_ENV
echo "ndk.dir=/usr/local/lib/android/sdk/ndk/${NDK_VERSION}" >> local.properties
ALL_FILES_ACCESS=${{ matrix.all_files_access }} ./scripts/ci/env_gh.sh
Expand Down
4 changes: 2 additions & 2 deletions cmake/Platform.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ endif()
if(ANDROID_ABI)
set(ANDROID_BUILD_TOOLS_VERSION "34.0.0" CACHE STRING "Android build-tools version")
set(ANDROID_TARGET_PLATFORM 34 CACHE INT "Target Android platform SDK version")
set(ANDROID_PLATFORM 21 CACHE INT "Minimum Android platform SDK version")
set(ANDROID_PLATFORM_INT 21 CACHE INT "Minimum Android platform SDK version") # Used in build.gradle.in
set(ANDROID_PLATFORM 23 CACHE INT "Minimum Android platform SDK version")
set(ANDROID_PLATFORM_INT 23 CACHE INT "Minimum Android platform SDK version") # Used in build.gradle.in
set(ANDROID_CPP_FEATURES "rtti exceptions")
endif()
1 change: 1 addition & 0 deletions vcpkg/triplets/arm-android.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ set(VCPKG_CMAKE_SYSTEM_NAME Android)
set(VCPKG_BUILD_TYPE release)
set(VCPKG_MAKE_BUILD_TRIPLET "--host=armv7a-linux-androideabi")
set(VCPKG_CMAKE_CONFIGURE_OPTIONS -DANDROID_ABI=armeabi-v7a -DANDROID_ARM_NEON=OFF)
set(VCPKG_CMAKE_SYSTEM_VERSION 23)
set(ANDROID_SDK_ROOT $ENV{ANDROID_SDK_ROOT})

set(VCPKG_CXX_FLAGS "-fstack-protector-strong")
Expand Down
1 change: 1 addition & 0 deletions vcpkg/triplets/arm-neon-android.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ set(VCPKG_CMAKE_SYSTEM_NAME Android)
set(VCPKG_BUILD_TYPE release)
set(VCPKG_MAKE_BUILD_TRIPLET "--host=armv7a-linux-androideabi")
set(VCPKG_CMAKE_CONFIGURE_OPTIONS -DANDROID_ABI=armeabi-v7a -DANDROID_ARM_NEON=ON)
set(VCPKG_CMAKE_SYSTEM_VERSION 23)
set(ANDROID_SDK_ROOT $ENV{ANDROID_SDK_ROOT})

set(VCPKG_CXX_FLAGS "-fstack-protector-strong")
Expand Down
1 change: 1 addition & 0 deletions vcpkg/triplets/arm64-android.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ set(VCPKG_CMAKE_SYSTEM_NAME Android)
set(VCPKG_BUILD_TYPE release)
set(VCPKG_MAKE_BUILD_TRIPLET "--host=aarch64-linux-android")
set(VCPKG_CMAKE_CONFIGURE_OPTIONS -DANDROID_ABI=arm64-v8a)
set(VCPKG_CMAKE_SYSTEM_VERSION 23)
set(ANDROID_SDK_ROOT $ENV{ANDROID_SDK_ROOT})

set(VCPKG_CXX_FLAGS "-fstack-protector-strong")
Expand Down
1 change: 1 addition & 0 deletions vcpkg/triplets/x64-android.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ set(VCPKG_CMAKE_SYSTEM_NAME Android)
set(VCPKG_BUILD_TYPE release)
set(VCPKG_MAKE_BUILD_TRIPLET "--host=x86_64-linux-android")
set(VCPKG_CMAKE_CONFIGURE_OPTIONS -DANDROID_ABI=x86_64)
set(VCPKG_CMAKE_SYSTEM_VERSION 23)
set(ANDROID_SDK_ROOT $ENV{ANDROID_SDK_ROOT})

set(VCPKG_CXX_FLAGS "-fstack-protector-strong")
Expand Down
1 change: 1 addition & 0 deletions vcpkg/triplets/x86-android.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ set(VCPKG_CMAKE_SYSTEM_NAME Android)
set(VCPKG_BUILD_TYPE release)
set(VCPKG_MAKE_BUILD_TRIPLET "--host=i686-linux-android")
set(VCPKG_CMAKE_CONFIGURE_OPTIONS -DANDROID_ABI=x86)
set(VCPKG_CMAKE_SYSTEM_VERSION 23)
set(ANDROID_SDK_ROOT $ENV{ANDROID_SDK_ROOT})

set(VCPKG_CXX_FLAGS "-fstack-protector-strong")
Expand Down

0 comments on commit a73b01d

Please sign in to comment.