Event queue optimizations #4571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for f8b5137: arm64-android |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright, this turned out to be quite an instructive investigation.
Animated QML items are great looking, but turns out they end up flooding the main app event queue, which in turn has some significant consequence when trying to invoke methods on the main app thread (e.g. rendering maps with data-defined expression that require a main thread method invocation).
The biggest issue here turned out to be the legend. Even if an animated item is not visible, the animation does run and does trigger a lot of event. In our case, we had an animated tracker badge for each legend item triggering events, which meant that a large project would create loads and loads of events.
Solution: if an animation isn't providing that much more visual feedback, kill it. If it's important or can be confined, insure it's only running when needed.