-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for tracking session to be resumed (inc. across QField restarts) #4590
Conversation
🎉 Ta-daaa, freshly created APKs are available for 5462f44: arm64-android |
fc3a4f7
to
245dfff
Compare
4a70ed9
to
376bf53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some styling comments
Few comments on the UI:
@lindacamathias can you test before me merge all of this, I am pretty sure you are more familiar with the context and will provide better user feedback. |
@suricactus , thanks for the review, I've added a bunch of missing documentation in projectinfo.h on top of the functions hinted at in your review. Regarding popup styling (and other possible UI improvements), I suggest we defer to another PR, this one is quite disruptive as it is. I don´t think we'd go fullcreen on this one as for tablets it'd look weird for both orientation, however we can reduce margins for narrow screen width. I'd be -1 on tabs in this UI in part because I think we want to keep most settings super quick to access. I have been trying to think of a way to visually regroup settings into themes (e.g. her we could have Constraints and General groups), it'd be useful here and in the settings panel. I haven't settled on the way it should be done visually yet though. I'm seeing margins for constraints and erroneous position sub-parameters here. If you have a photo of the bottom padding issue on Qt6, could you attach here? |
4c7ebb6
to
886f51e
Compare
(note that the client sponsoring this feature has done some testing already, which revealed a couple of regressions that have been addressed) |
c2f30b9
to
5462f44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR and speedy update of the UI. Looks perfect now!
@suricactus , thanks for the crucial pair of eyes and suggestions, made a huge difference. |
This PR adds the infrastructure to resume tracking sessions (including across QField reboots/restarts). When a tracking session has previously been started, QField now offers to resume the last session:
Practically, it means that for lines and polygons, the created feature from the previous session is carried over.
In order to be able to restore tracking sessions across QField launches, or pause/resume tracks within a same session, we need to decouple the tracking settings UI from the tracking session item. Doing so actually makes the handling of tracks a little bit easier to understand, and avoids mixing UI and core elements together.
The newly added TrackerSettings.qml is essentially the popup part of TrackingSession.qml taken out.
I've taken the time to clean up the tracking model a fairbit and add missing data() roles as well as guarding against invalid row index.