Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify logic of checking for failing hard/soft constraints in tabs/containers #4596

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Sep 24, 2023

@qfield-fairy
Copy link
Collaborator

Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the review I decided I first check the old code to see if you missed something. I was expecting a recursion there but... So the PR is implementing the exact logic I would apply. Good move.

@nirvn nirvn merged commit 71e1414 into master Sep 27, 2023
19 checks passed
@nirvn nirvn deleted the why branch September 27, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants