Simplify logic of checking for failing hard/soft constraints in tabs/containers #4596
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, unsure why I went for the hyper convoluted way before now, but this code is much, much cleaner.
Hoping this will fix some crash reported on sentry, e.g.:
https://opengisch.sentry.io/issues/4307906818/?project=6119013&query=is%3Aunresolved+child&referrer=issue-stream&statsPeriod=14d&stream_index=1
https://opengisch.sentry.io/issues/4483277442/?project=6119013&query=is%3Aunresolved+child&referrer=issue-stream&statsPeriod=14d&stream_index=3
https://opengisch.sentry.io/issues/4341391515/?project=6119013&query=is%3Aunresolved+child&referrer=issue-stream&statsPeriod=14d&stream_index=4
I can't reproduce myself but I'm hoping the simplified code will fix things.