Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkbox editor widget against datasets delivering boolean fields as strings #4597

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Sep 24, 2023

Fix for a regression seen running against QGIS master.

@nirvn
Copy link
Member Author

nirvn commented Sep 24, 2023

@suricactus , if you can think of a better way to detect whether value is a string other than by checking for presence of the toLowerCase function, I'm all ears :)

@qfield-fairy
Copy link
Collaborator

qfield-fairy commented Sep 24, 2023

Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the weird check the code looks good. Have not checked functionally what it fixed.

@nirvn nirvn enabled auto-merge (rebase) September 27, 2023 02:11
@nirvn nirvn merged commit 3c67836 into master Sep 27, 2023
19 checks passed
@nirvn nirvn deleted the checkbox_corner branch September 27, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants