Make deltas prepared for cloud projects play nicely with tracking features #4599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvn
force-pushed
the
cloud_tracking_friendly
branch
from
4fe5a0e
to
ecc52df
Compare
|
🎉 Ta-daaa, freshly created APKs are available for 789a167: arm64-android |
nirvn
force-pushed
the
cloud_tracking_friendly
branch
from
d09c33e
to
3857eae
Compare
nirvn
force-pushed
the
cloud_tracking_friendly
branch
from
3857eae
to
789a167
Compare
|
@suricactus , tests added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to avoid excessively large delta file (and changes count) being uploaded to QFieldCloud for vector layer features being used in tracking sessions.
The logic goes as follows: if a feature being updated is confirmed by the tracking model as part of an ongoing tracking session, new code attempts to find a geometry-only patch; if we find one, we update the new geometry with the latest geometry from the current tracking session.This makes the cloud experience tracker-friendly while not disrupting any logic on non-tracked features/layers.The logic goes as follows: if a feature being updated had a previous patch inserted into the deltas, we update that patch with the latest geometry/attribute changes. A few benefits from this approach include:
@suricactus , @m-kuhn , as discussed yesterday.
@GuyGeneau , this should help with the issue you filed here (#4578).