Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest feature form tabs on confirmed or cancelled. #5436

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

mohsenD98
Copy link
Collaborator

@mohsenD98 mohsenD98 commented Jul 10, 2024

This PR tries to resolve this issue:

Steps to remake issue:

  • Select the apiary layer in the legend, then insure that editing is ON
  • Add an apiary point onto the map (fill in the required info), and make sure you click on the OK check mark button when - you are in the 2nd or 3rd tab.
  • Then when the form is gone, add another apiary point.
  • You'll see the feature form opens at the tab you last had focused.
  • What we should do here is that when we create a new feature, it should reset to the 1st tab.

Fix:
we add a reset tab function in FeatureForm.qml and after confirm or cancel we call that.

Closes #5417

@mohsenD98 mohsenD98 self-assigned this Jul 10, 2024
@mohsenD98 mohsenD98 requested a review from nirvn July 10, 2024 13:46
Copy link
Member

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohsenD98 , this fixes an issue right?

@mohsenD98
Copy link
Collaborator Author

@mohsenD98 , this fixes an issue right?

Yes this one

@suricactus
Copy link
Collaborator

@mohsenD98 if you write "fixes #5417" or "fix #5417" in the opening message of the PR, github will automatically close the ticket if it is an issue. Not so sure about discussions, but let's see.

Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nirvn nirvn merged commit bbfa725 into master Jul 12, 2024
21 of 23 checks passed
@nirvn nirvn deleted the reset_tabs_on_opening_feature_form branch July 12, 2024 13:44
@Ipickedausername
Copy link

This PR must also fixes the issue I raised a while ago : #4512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants