Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve robustness of our handling of file path to source URLs #5528

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Aug 7, 2024

Superseding #5527

@boardend , I'm hopeful we're getting there.

@qfield-fairy
Copy link
Collaborator

qfield-fairy commented Aug 7, 2024

test/spix/smoke_test.py Outdated Show resolved Hide resolved
@m-kuhn
Copy link
Member

m-kuhn commented Aug 7, 2024

Amazing work on spix side !!
Can you add a few tests on functional side on url side (this will document the expected behavior of the new method much better than a simple "image shows")

@nirvn nirvn enabled auto-merge August 7, 2024 12:59
@nirvn nirvn merged commit 6e7c2a4 into release-3_3 Aug 7, 2024
23 checks passed
@nirvn nirvn deleted the huh branch August 7, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants