Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project variables #5577

Merged
merged 8 commits into from
Aug 25, 2024
Merged

Project variables #5577

merged 8 commits into from
Aug 25, 2024

Conversation

mohsenD98
Copy link
Collaborator

@mohsenD98 mohsenD98 commented Aug 19, 2024

This PR enhances the existing settings page by introducing project variables to the list of displayed variables. This feature allows users to conveniently view all relevant project-specific variables.

wastewater management sample project:

image

@mohsenD98 mohsenD98 requested a review from nirvn August 19, 2024 17:15
@mohsenD98 mohsenD98 self-assigned this Aug 19, 2024
@mohsenD98 mohsenD98 changed the title Project variables WIP Project variables Aug 19, 2024
@mohsenD98 mohsenD98 marked this pull request as draft August 19, 2024 17:16
@qfield-fairy
Copy link
Collaborator

qfield-fairy commented Aug 19, 2024

@nirvn nirvn closed this Aug 21, 2024
@nirvn nirvn reopened this Aug 21, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/core/expressionvariablemodel.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/core/expressionvariablemodel.cpp Outdated Show resolved Hide resolved
src/qml/VariableEditor.qml Outdated Show resolved Hide resolved
src/core/expressionvariablemodel.h Outdated Show resolved Hide resolved
src/core/expressionvariablemodel.h Outdated Show resolved Hide resolved
@mohsenD98 mohsenD98 marked this pull request as ready for review August 24, 2024 08:59
@mohsenD98 mohsenD98 changed the title WIP Project variables Project variables Aug 24, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/core/expressionvariablemodel.cpp Show resolved Hide resolved
@m-kuhn m-kuhn closed this Aug 25, 2024
@m-kuhn m-kuhn reopened this Aug 25, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/core/expressionvariablemodel.cpp Show resolved Hide resolved
@nirvn nirvn merged commit 9eb5430 into master Aug 25, 2024
37 of 47 checks passed
@nirvn nirvn deleted the project-variables branch August 25, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants