Fix interrepo android build #5620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-kuhn
force-pushed
the
fix-interrepo-build
branch
from
01db247
to
e910256
Compare
m-kuhn
force-pushed
the
fix-interrepo-build
branch
5 times, most recently
from
147d126
to
497862f
Compare
nirvn
reviewed
Sep 7, 2024
Comment on lines
1
to
3
| if(NOT "ENV{KEYNAME}x" STREQUAL "x" | ||
| AND NOT "ENV{KEYPASS}x" STREQUAL "x" | ||
| AND NOT "ENV{STOREPASS}x" STREQUAL "x") |
There was a problem hiding this comment.
Just managed to build via docker locally, adding a $ worked for me:
Suggested change
| if(NOT "ENV{KEYNAME}x" STREQUAL "x" | |
| AND NOT "ENV{KEYPASS}x" STREQUAL "x" | |
| AND NOT "ENV{STOREPASS}x" STREQUAL "x") | |
| if(NOT "$ENV{KEYNAME}x" STREQUAL "x" | |
| AND NOT "$ENV{KEYPASS}x" STREQUAL "x" | |
| AND NOT "$ENV{STOREPASS}x" STREQUAL "x") |
There was a problem hiding this comment.
Just managed to build via docker locally, adding a $ worked for me:
A lot of implicit knowledge required for expansion in if https://cmake.org/cmake/help/latest/command/if.html
There is no automatic evaluation for environment or cache Variable References. Their values must be referenced as $ENV{} or $CACHE{} wherever the above-documented condition syntax accepts <variable|string>.
m-kuhn
force-pushed
the
fix-interrepo-build
branch
2 times, most recently
from
f0d608a
to
d55a65b
Compare
m-kuhn
force-pushed
the
fix-interrepo-build
branch
from
d55a65b
to
75b4db9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.