Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QFieldGuide component: adjust pointerToItem. #5709

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

mohsenD98
Copy link
Collaborator

PR description:

Somehow (!) pointer to item of QFieldGuide is out of sync!

image

this commit fixes that with more enhanced logic!

@mohsenD98 mohsenD98 requested a review from nirvn October 2, 2024 13:41
@mohsenD98 mohsenD98 self-assigned this Oct 2, 2024
@nirvn
Copy link
Member

nirvn commented Oct 2, 2024

I suspect this regressed at the 11th hour when we jumped back to qt 6.6.3.

Let's remember to check again when we go up to 6.7.3.

@mohsenD98
Copy link
Collaborator Author

I suspect this regressed at the 11th hour when we jumped back to qt 6.6.3.

Let's remember to check again when we go up to 6.7.3.

Agree

@mohsenD98 mohsenD98 closed this Oct 2, 2024
@mohsenD98 mohsenD98 reopened this Oct 2, 2024
@qfield-fairy
Copy link
Collaborator

@mohsenD98 mohsenD98 marked this pull request as ready for review October 2, 2024 14:21
Copy link
Member

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tested on Android; looks good.

@nirvn nirvn merged commit b6f3329 into master Oct 2, 2024
30 of 49 checks passed
@nirvn nirvn deleted the fix-guides branch October 2, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants