Support grid decoration #5714
Merged
Support grid decoration #5714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for 6b7afc7: arm64-android |
mohsenD98
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds grid decoration functionality to QField:
vokoscreenNG-2024-10-05_11-55-28.mp4
QField will enable the grid based on the currently opened project's grid decoration settings, which is configured when preparing a project in QGIS. Implementation note: as with other decorations implemented in QField, we do not do a 1-to-1 implementation; in this case, we will take the line or maker color defined in QGIS but we will render the line and marker style our own way (namely non-dashed lines and cross markers).
Quite interestingly, relying on QML Shape rendering ended up being much faster than relying on a QQuickPaintedItem and doing the rendering completely on the C++ side of things. That was surprising to me, and serves as a good reminder that QML scenes have excellent rendering speeds!
Sample project showcasing grid:
grid_Sample_project.zip