Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing / measuring tool bug fix #5736

Merged
merged 3 commits into from
Oct 19, 2024
Merged

Conversation

mohsenD98
Copy link
Collaborator

@mohsenD98 mohsenD98 commented Oct 15, 2024

PR Description:

When users are in the algorithm design mode and attempt to navigate to the measurement section, the preview feature remains active, which is an unauthorized behavior. This pull request addresses and resolves that issue.

Solution:

To prevent users from entering the measurement section while still in the algorithm design mode, we will implement a confirmation dialog. This dialog will prompt the user with the question: “Do you want to discard the algorithm to enter the measurement section?”

If the user accepts, the algorithm will be discarded, allowing for a proper transition to the measurement section.

This change aims to enhance user experience by ensuring that the application behaves predictably and maintains the integrity of the design process.

Changes Made:

Added a confirmation dialog for transitioning from algorithm design to measurement.
Managed state transitions effectively based on user input.

Before and After Demo:

Screencast.from.2024-10-17.18-18-35.webm

@mohsenD98 mohsenD98 requested a review from nirvn October 15, 2024 13:06
@mohsenD98 mohsenD98 self-assigned this Oct 15, 2024
@mohsenD98 mohsenD98 changed the title Show a discarding dialog. Processing / measuring tool bug fix Oct 15, 2024
@mohsenD98 mohsenD98 force-pushed the processing-measuring-tool-bug-fix branch from 1135dc4 to 580f184 Compare October 15, 2024 13:16
@mohsenD98 mohsenD98 force-pushed the processing-measuring-tool-bug-fix branch from 580f184 to 817a95c Compare October 15, 2024 13:21
@qfield-fairy
Copy link
Collaborator

qfield-fairy commented Oct 15, 2024

@mohsenD98 mohsenD98 changed the title Processing / measuring tool bug fix WIP: Processing / measuring tool bug fix Oct 16, 2024
@mohsenD98 mohsenD98 changed the title WIP: Processing / measuring tool bug fix Processing / measuring tool bug fix Oct 17, 2024
src/qml/qgismobileapp.qml Outdated Show resolved Hide resolved
src/qml/qgismobileapp.qml Outdated Show resolved Hide resolved
@nirvn nirvn merged commit 2349d17 into master Oct 19, 2024
21 of 23 checks passed
@nirvn nirvn deleted the processing-measuring-tool-bug-fix branch October 19, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants