refactor(url): not finding a short link for a user should be construe…

…d as unauthorized update
opengovsg · Sep 28, 2020 · 2563b1f · 2563b1f
1 parent 86a5de3
commit 2563b1f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/src/server/controllers/UserController.ts b/src/server/controllers/UserController.ts
@@ -114,7 +114,7 @@ export class UserController implements UserControllerInterface {
       return
     } catch (error) {
       if (error instanceof NotFoundError) {
-        res.notFound(jsonMessage(error.message))
+        res.forbidden(jsonMessage(error.message))
         return
       }
       logger.error(`Error editing URL:\t${error}`)

diff --git a/src/server/util/response.ts b/src/server/util/response.ts
@@ -16,6 +16,9 @@ response.badRequest = function (content) {
 response.unauthorized = function (content) {
   this.status(401).send(content)
 }
+response.forbidden = function (content) {
+  this.status(403).send(content)
+}
 response.notFound = function (content) {
   this.status(404).send(content)
 }

diff --git a/src/types/server/api/express.d.ts b/src/types/server/api/express.d.ts
@@ -11,6 +11,7 @@ declare global {
       created(content?: Buffer | object | string): void
       badRequest(content?: Buffer | object | string): void
       unauthorized(content?: Buffer | object | string): void
+      forbidden(content?: Buffer | object | string): void
       notFound(content?: Buffer | object | string): void
       unsupportedMediaType(content?: Buffer | object | string): void
       unprocessableEntity(content?: Buffer | object | string): void