test: fix broken tests

opengovsg · Sep 19, 2020 · 5f2b0a3 · 5f2b0a3
1 parent 1130d54
commit 5f2b0a3
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 6 deletions.
diff --git a/test/server/controllers/RedirectController.test.ts b/test/server/controllers/RedirectController.test.ts
@@ -331,7 +331,8 @@ describe('redirect API tests', () => {
     const req = createRequestWithShortUrl('Aaa')
     const res = httpMocks.createResponse()
 
-    redisMockClient.set('aaa', 'aa')
+    const longUrlAndDescription = { longUrl: 'aa', description: 'bbb' }
+    redisMockClient.set('aaa', JSON.stringify(longUrlAndDescription))
     mockDbEmpty()
 
     await container
@@ -349,7 +350,8 @@ describe('redirect API tests', () => {
     const res = httpMocks.createResponse()
 
     mockDbDown()
-    redisMockClient.set('aaa', 'aa')
+    const longUrlAndDescription = { longUrl: 'aa', description: 'bbb' }
+    redisMockClient.set('aaa', JSON.stringify(longUrlAndDescription))
 
     await container
       .get<RedirectController>(DependencyIds.redirectController)

diff --git a/test/server/mocks/repositories/UrlRepository.ts b/test/server/mocks/repositories/UrlRepository.ts
@@ -35,6 +35,12 @@ export class UrlRepositoryMock implements UrlRepositoryInterface {
     throw new Error('Not implemented')
   }
 
+  getLongUrlAndDescription: (
+    shortUrl: string,
+  ) => Promise<{ longUrl: string; description: string }> = () => {
+    throw new Error('Not implemented')
+  }
+
   plainTextSearch: (
     query: string,
     order: SearchResultsSortOrder,

diff --git a/test/server/repositories/UrlRepository.test.ts b/test/server/repositories/UrlRepository.test.ts
@@ -307,7 +307,8 @@ describe('UrlRepository', () => {
     })
 
     it('should return from cache when cache is filled', async () => {
-      redisMockClient.set('a', 'aaa')
+      const longUrlAndDescription = { longUrl: 'aaa', description: 'bbb' }
+      redisMockClient.set('a', JSON.stringify(longUrlAndDescription))
       await expect(repository.getLongUrl('a')).resolves.toBe('aaa')
     })
 
@@ -332,10 +333,10 @@ describe('UrlRepository', () => {
     })
 
     it('should return from cache when cache is filled', async () => {
-      const json = JSON.stringify({ longUrl: 'aaa', description: 'bbb' })
-      redisMockClient.set('a', json)
+      const longUrlAndDescription = { longUrl: 'aaa', description: 'bbb' }
+      redisMockClient.set('a', JSON.stringify(longUrlAndDescription))
       await expect(repository.getLongUrlAndDescription('a')).resolves.toEqual(
-        json,
+        longUrlAndDescription,
       )
     })
 

diff --git a/test/server/services/UrlManagementService.test.ts b/test/server/services/UrlManagementService.test.ts
@@ -19,6 +19,7 @@ describe('UrlManagementService', () => {
     create: jest.fn(),
     findByShortUrl: jest.fn(),
     getLongUrl: jest.fn(),
+    getLongUrlAndDescription: jest.fn(),
     plainTextSearch: jest.fn(),
   }