Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace jsdom and d3 libraries with leaner libraries such as cheeriojs #1284

Closed
orbitalsqwib opened this issue Mar 9, 2021 · 0 comments · Fixed by #1286
Closed

Replace jsdom and d3 libraries with leaner libraries such as cheeriojs #1284

orbitalsqwib opened this issue Mar 9, 2021 · 0 comments · Fixed by #1286

Comments

@orbitalsqwib
Copy link
Contributor

Currently, the jsdom and d3 libraries have been imported to generate HTML for the QRCodeService module.

However, we only use a small subset of the functionalities contained within these libraries.

As such, we could look into alternative replacements to reduce the memory footprint of the client app and decrease loading times.

One suggestion is cheeriojs, a Javascript library that can parse, traverse and manipulate HTML, but does not implement features such as visual rendering, applying CSS, loading external resources, or executing JavaScript. I think it's a close match for our needs.

Metrics that can be used to measure the effectiveness of this proposal include the client app load time as well as the time taken to generate QR Codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant