Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use maildev for local development #951

Closed
liangyuanruo opened this issue Nov 23, 2020 · 2 comments · Fixed by #1339
Closed

Use maildev for local development #951

liangyuanruo opened this issue Nov 23, 2020 · 2 comments · Fixed by #1339
Labels
P2 Not urgent, but work on it once you're done with current tasks security

Comments

@liangyuanruo
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently local development requires hardcoding OTPs to "111111" and using the dummy MailerNoOp service.

Describe the solution you'd like
Integrate maildev with for use in local development instead. This will close the security risks from accidentally generating dummy OTPs in production, and align development to be closer to the production setup.
@liangyuanruo liangyuanruo added security P2 Not urgent, but work on it once you're done with current tasks labels Nov 23, 2020
@LoneRifle
Copy link
Contributor

Instead of that, why not we just stub nodemailer in dev?

@liangyuanruo
Copy link
Contributor Author

I would like to exercise the same nodemailer code path as closely as possible. wit this implementation, the difference will be minimal as only the transport will differ.

LoneRifle pushed a commit that referenced this issue Mar 22, 2021
@orbitalsqwib @LoneRifle
build(email): implement maildev for local development
d34d950 
Currently local development requires hardcoding OTPs to "111111" and using the dummy MailerNoOp
service.

-implemented maildev for local development
-added an environment variable to toggle
maildev, defaults to true

fix #951
orbitalsqwib added a commit that referenced this issue Mar 22, 2021
@orbitalsqwib
test(login-procedure): integrate maildev into login procedures
06982d0 
fix #951
orbitalsqwib added a commit that referenced this issue Mar 22, 2021
@orbitalsqwib
refactor(maildev): refactor maildev for permanent use in dev
c561652 
- Removed MailerNoOp and Nodemailer Direct Transport
- Removed `USE_MAILDEV` env var
- Refactored code paths to always use maildev for development
- Improved LoginProcedure to use regex to find OTP

fix #951
@orbitalsqwib orbitalsqwib mentioned this issue Mar 22, 2021
Merged
orbitalsqwib added a commit that referenced this issue Mar 23, 2021
@orbitalsqwib
refactor(transport-options): refactor nodemailer transport options
292e63c 
- Refactored Nodemailer transport option configurations for clarity
- Cleaned up email, inversify and config files

fix #951
orbitalsqwib added a commit that referenced this issue Mar 23, 2021
@orbitalsqwib
build(maildev): remove maildev from dependencies
e1bee6c 
- Removed maildev from dependencies as maildev is currently run through a docker container

fix #951
orbitalsqwib added a commit that referenced this issue Mar 23, 2021
@orbitalsqwib
refactor(config): move otpfunction declaration to definition
6a8248e 
fix #951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Not urgent, but work on it once you're done with current tasks security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(maildev): implement maildev for development opengovsg/GoGovSG
2 participants
@liangyuanruo @LoneRifle