Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move sentry, user codebase to modules #1002

Merged
merged 3 commits into from
Dec 2, 2020
Merged

refactor: move sentry, user codebase to modules #1002

merged 3 commits into from
Dec 2, 2020

Conversation

LoneRifle
Copy link
Contributor

Problem

Ongoing work for #869

Solution

  • create the sentry module, move controller, service therein
  • create the user module, move controller, services, types therein
  • eliminate controller and service interfaces

@LoneRifle
test(jest): exclude __tests__ from coverage
044f7ea
@LoneRifle
refactor(sentry): move into module
16640f0
@LoneRifle
refactor(user): convert to module
2caf6fa 
- create the user module, move controller, services, types therein
- eliminate controller and service interfaces
@LoneRifle LoneRifle merged commit d343934 into develop Dec 2, 2020
@liangyuanruo liangyuanruo deleted the refactor/modules branch December 2, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangyuanruo liangyuanruo liangyuanruo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LoneRifle @liangyuanruo