Search full shorturl #1037
Merged
Search full shorturl #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove rawdirectory search from urlrepository - shift preprocess task to directorysearchservice
- rename sanitse file to parse file - extract shorturl that contains the full url link from query
- add new tests for extractshorturl - update directory related tests from refactor
LoneRifle
requested changes
Dec 10, 2020
LoneRifle
reviewed
Dec 10, 2020
- move preprocess back to urlrepository - add back rawdirectorysearch - revert back tests
LoneRifle
requested changes
Dec 10, 2020
yong-jie
requested changes
Dec 11, 2020
LoneRifle
reviewed
Dec 14, 2020
yong-jie
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users are unable to search for shortUrl when they enter the entire url in the search box e.g. https://go.gov.sg/search-this.
Closes #977
Solution
Add another layer for keyword search to extract the shortUrl if the search query matches the regex pattern.
e.g. https://go.gov.sg/search-this will extract search-this
If it does not match the regex, the original query will be used
Exclude query without https header
e.g. go.gov.sg/search-this as users only search (guessing it is a copy and paste action) the full url link (as found in GA)