Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: directory toggle ui #1038

Merged
merged 1 commit into from
Dec 14, 2020
Merged

fix: directory toggle ui #1038

merged 1 commit into from
Dec 14, 2020

Conversation

Oxiang
Copy link
Contributor

@Oxiang Oxiang commented Dec 10, 2020

Problem

The arrow in the directory page toggle have been shifted down

Solution

Change the css from inline-block to box

Before & After Screenshots

BEFORE:
Screenshot 2020-12-10 at 10 45 19 AM

AFTER:
Screenshot 2020-12-10 at 11 01 08 AM

@Oxiang Oxiang requested review from LoneRifle and yong-jie December 10, 2020 03:14
LoneRifle
LoneRifle approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm alright if the designers are alright with it - last I remembered the wireframes deliberately wanted it that way

@Oxiang Oxiang merged commit 1b0ae61 into develop Dec 14, 2020
@Oxiang Oxiang deleted the ui-fix branch December 14, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoneRifle LoneRifle LoneRifle approved these changes

@yong-jie yong-jie Awaiting requested review from yong-jie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oxiang @LoneRifle