Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display longurl in directory page #1068

Merged
merged 3 commits into from
Dec 16, 2020
Merged

Display longurl in directory page #1068

merged 3 commits into from
Dec 16, 2020

Conversation

Oxiang
Copy link
Contributor

@Oxiang Oxiang commented Dec 16, 2020

Problem

If we were to allow searching by long link, we should also show the user the long link in the search results.

Closes #1059

Solution

  • Include longUrl in the result from endpoint
  • Include longUrl in the result found on directory page
  • Update directory related tests

Before & After Screenshots

AFTER:
Web dashboard
Screenshot 2020-12-15 at 2 21 15 PM

Mobile dashboard
Screenshot 2020-12-16 at 10 09 51 AM

Mobile drawer
Screenshot 2020-12-16 at 10 09 32 AM

Copy link
Contributor

@liangyuanruo liangyuanruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liangyuanruo liangyuanruo merged commit be7b89e into develop Dec 16, 2020
@liangyuanruo liangyuanruo deleted the display-longurl branch December 16, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display long link in GoDirectory search results
2 participants