Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved stylings for table footer #112

Merged
merged 1 commit into from
May 22, 2020
Merged

Improved stylings for table footer #112

merged 1 commit into from
May 22, 2020

Conversation

kylerwsm
Copy link
Contributor

Problem

  • Removed the use of negative margins to center the table footer.
  • This solution makes use of absolute positioning.

@kylerwsm kylerwsm requested a review from JasonChong96 May 22, 2020 15:34
@kylerwsm kylerwsm marked this pull request as ready for review May 22, 2020 15:35
JasonChong96
JasonChong96 approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@JasonChong96 JasonChong96 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow absolute didn't work when i tried but gj getting it to work. lgtm

@JasonChong96 JasonChong96 merged commit 7977fc2 into user-page-table-footer May 22, 2020
JasonChong96 added a commit that referenced this pull request May 22, 2020
@JasonChong96 @kylerwsm
User page table footer (#108)
9926c3d 
* Fix user page footer

* Move styles into its own file

* Make image undraggable

* improved stylings for table footer (#112)

Co-authored-by: Kyler Wong <wsm.kyler@gmail.com>
@kylerwsm kylerwsm deleted the table-footer-mod branch June 25, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonChong96 JasonChong96 JasonChong96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylerwsm @JasonChong96