Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(modules): make auth module for login/out #1172

Merged
merged 1 commit into from
Feb 10, 2021
Merged

refactor(modules): make auth module for login/out #1172

merged 1 commit into from
Feb 10, 2021

Conversation

LoneRifle
Copy link
Contributor

Context

  • Move LoginController, LogoutController, and supporting cast into modules/auth
  • Rework tests to use Jest functions where appropriate, to decouple from test/

Part of routine work for #869

@LoneRifle LoneRifle requested a review from yong-jie February 8, 2021 04:19
@LoneRifle
refactor(modules): make auth module for login/out
7c96b56 
Rework the tests for LoginController
@LoneRifle LoneRifle force-pushed the refactor/modules/auth branch from 72ac31c to 7c96b56 Compare February 8, 2021 06:30
yong-jie
yong-jie approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yong-jie yong-jie merged commit ba962e3 into develop Feb 10, 2021
@yong-jie yong-jie deleted the refactor/modules/auth branch February 10, 2021 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yong-jie yong-jie yong-jie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LoneRifle @yong-jie