Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url click table migration cleanup #1190

Merged
merged 5 commits into from
Feb 15, 2021
Merged

Url click table migration cleanup #1190

merged 5 commits into from
Feb 15, 2021

Conversation

yong-jie
Copy link
Member

Problem

There are a few outstanding issues surrounding the url click table migration that needs to be cleaned up.

Closes #1097

Solution

  • Change upsert to create in url's onCreate hook
  • Remove unnecessary typecast of the transition object in create
  • Rename findByUrl to findByUrlWithTotalClicks for better clarity

@yong-jie yong-jie requested a review from LoneRifle February 14, 2021 14:15
LoneRifle
LoneRifle approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LoneRifle LoneRifle merged commit ab70201 into develop Feb 15, 2021
@LoneRifle LoneRifle deleted the url-click-cleanup branch February 15, 2021 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoneRifle LoneRifle LoneRifle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update onCreate hook for Urls model after migration is complete
2 participants
@yong-jie @LoneRifle