fix(minimatch): enable extglobs for e-mail domain whitelists #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To facilitate matching of specific domains in e-mail addresses, we have to configure minimatch to accept extglobs, so that we can match against a selection of specific domains, eg: *@+(open|schools).gov.sg
yong-jie
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Minimatch is currently used in Go.gov.sg with extglobs disabled, which prevents us from
expressing a valid glob expression in terms of specific e-mail domains
Part of work for #777
Solution
To facilitate matching of specific domains in e-mail addresses, we have
to configure minimatch to accept extglobs, so that we can match against
a selection of specific domains, eg:
*@+(open|schools).gov.sgTake the opportunity to also enable builds to the new edu-focused environments