Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sentry): use @sentry/react #1220

Merged
merged 3 commits into from
Feb 23, 2021
Merged

feat(sentry): use @sentry/react #1220

merged 3 commits into from
Feb 23, 2021

Conversation

LoneRifle
Copy link
Contributor

@LoneRifle LoneRifle commented Feb 23, 2021

Problem

Closes #952

Solution

Drop @sentry/react in to replace @sentry/browser

New dependencies:

  • @sentry/react : 1-for-1 replacement for @sentry/browser

Drop @sentry/react in to replace @sentry/browser
Copy link
Contributor

@liangyuanruo liangyuanruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put in the integration for Redux and React Router?

Replace HashRouter with Router and hash history to hook Sentry in
@liangyuanruo liangyuanruo changed the title refactor(sentry): use @sentry/react feat(sentry): use @sentry/react Feb 23, 2021
Copy link
Contributor

@liangyuanruo liangyuanruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@LoneRifle LoneRifle merged commit 4bfb73a into develop Feb 23, 2021
@liangyuanruo liangyuanruo deleted the refactor/sentry/react branch February 23, 2021 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve client-side monitoring with @sentry/react
2 participants