-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with gitpod #123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoneRifle
force-pushed
the
gitpod1
branch
16 times, most recently
from
June 8, 2020 15:59
7e9ce1f
to
478d9cf
Compare
LoneRifle
force-pushed
the
gitpod1
branch
3 times, most recently
from
June 9, 2020 05:27
bd1078c
to
9365830
Compare
LoneRifle
force-pushed
the
gitpod1
branch
5 times, most recently
from
June 9, 2020 06:08
8615067
to
40b7ec2
Compare
- Get gitpod docker to install localstack and deps and env vars, and create a directory for localstack bootstrap scripts - At runtime, in a separate window, stash init-localstack.sh where localstack will find it, and start localstack in host mode (since we are already using it within docker) - Ignore ports opened by localstack
Verified that I am able to carry out core functionality such as creating/editing links, ownership transfers, and even file uploads in gitpod. |
Take advantage of globs supported by webpack-dev-server to route everything that is not `/assets` or `/bundle.js` to expressjs. As a result, we can now have everything run out of port 3000 via proxy, even the short-links themselves
liangyuanruo
approved these changes
Jun 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates our codebase with Gitpod, allowing users to start developing/testing code without the need to set up any infrastructure on their computer. This is also useful for open-source contributors who would like to briefly check out the codebase to develop and fix bugs, etc.
The integration with gitpod is done primarily through two files: 1) the gitpod config file which states the ports and processes to run, and also 2) the custom gitpod dockerfile that contains all the dependencies installed on it.