Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with gitpod #123

Merged
merged 12 commits into from
Jun 10, 2020
Merged

Integration with gitpod #123

merged 12 commits into from
Jun 10, 2020

Conversation

yong-jie
Copy link
Member

@yong-jie yong-jie commented May 27, 2020

This PR integrates our codebase with Gitpod, allowing users to start developing/testing code without the need to set up any infrastructure on their computer. This is also useful for open-source contributors who would like to briefly check out the codebase to develop and fix bugs, etc.

The integration with gitpod is done primarily through two files: 1) the gitpod config file which states the ports and processes to run, and also 2) the custom gitpod dockerfile that contains all the dependencies installed on it.

@LoneRifle LoneRifle force-pushed the gitpod1 branch 3 times, most recently from bd1078c to 9365830 Compare June 9, 2020 05:27
@LoneRifle LoneRifle force-pushed the gitpod1 branch 5 times, most recently from 8615067 to 40b7ec2 Compare June 9, 2020 06:08
- Get gitpod docker to install localstack and deps and env vars,
  and create a directory for localstack bootstrap scripts
- At runtime, in a separate window, stash init-localstack.sh where
  localstack will find it, and start localstack in host mode (since
  we are already using it within docker)
- Ignore ports opened by localstack
@LoneRifle LoneRifle marked this pull request as ready for review June 9, 2020 06:24
@LoneRifle LoneRifle changed the title [WIP] Integration with gitpod Integration with gitpod Jun 9, 2020
@yong-jie
Copy link
Member Author

yong-jie commented Jun 9, 2020

Verified that I am able to carry out core functionality such as creating/editing links, ownership transfers, and even file uploads in gitpod.

Take advantage of globs supported by webpack-dev-server to route
everything that is not `/assets` or `/bundle.js` to expressjs.
As a result, we can now have everything run out of port 3000 via proxy,
even the short-links themselves
Copy link
Contributor

@liangyuanruo liangyuanruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liangyuanruo liangyuanruo merged commit 70ee475 into develop Jun 10, 2020
@liangyuanruo liangyuanruo deleted the gitpod1 branch June 10, 2020 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants