Introduce link statistics csv download #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add `offset` to joi validator
LoneRifle
approved these changes
Feb 24, 2021
| import { useDrawerState } from '../../../../index' | ||
|
|
||
| async function downloadClicks(shortUrl: string, onError: () => void) { | ||
| const offsetDays = 3650 |
There was a problem hiding this comment.
ten years of statistics? is that going to be okay?
There was a problem hiding this comment.
discussed that the server presently has no issues with the amount of data to fetch and should not be an issue for awhile, at least until we allow more control over the period of data to download.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users have been reaching out to us to retrieve their past link statistics. This feature allows them to download the full link statistics in a CSV format.
Closes #1155
Solution
There is an existing API route used by link stats graph to fetch the last 7 days of clicks. I modified it to allow the number of days to be customisable via URL query params. This approach maximises code reuse and opens future opportunities to allow more days of data to be displayed in link stats graphs.
Also added a button in frontend to call the API and generate CSV.
Before & After Screenshots
AFTER:
