Fix IE11 UI Elements #126
Merged
Fix IE11 UI Elements #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonChong96
requested review from
liangyuanruo,
yong-jie and
kylerwsm
and removed request for
liangyuanruo
liangyuanruo
approved these changes
May 29, 2020
|
Tested on IE11 and things look fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The UI looks weird on IE11. One of the issues is that the sort panel is out of position as IE11. Another is that icon sizes are off and some flexbox positioning is wrong
[Closes #125 and #127]
Solution
Explicitly set left position so IE11 places the panel on the left of the div
Fix flexbox positioning of sort buttons
Change box-icons to be local. Removed box-icons dependency
Icons that require reuse of different sizes/colors have been extracted as react components to directly change the viewport size and fill for IE11 compatibility
Before & After Screenshots
AFTER:
(IE11)
Main page
Filter panel
Drawer
Create link
Small main page
Create link small
Sort panel small
Create link smaller