refactor(locales): move to using static file #1275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to use a single codebase for several similar deployments, but
with different themes and copywriting text. To that end, we need resource strings
to be easily substitutable. As of now, they are implemented as a TypeScript module
webpacked into the bundle
Part of work for #777
Solution
Move translation resource strings to static file, so that we can easily
substitute such files for deployments using the Go.gov.sg codebase
npm install i18next-http-backend
app/assets/.../translation
->public/locales/.../translation.json
string interpolation were doing in the
app/assets
ts filetranslations from a static path instead of having it injected into
the config
<Trans>
elements for i18next.t callsDeploy Notes
New dependencies:
i18next-http-backend
: backend that fetches translations from a defined path