refactor(pages): drop govtech-sgds via jsdelivr #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transition and 404 pages currently have a dependency on govtech-sgds, delivered via cdn.jsdelivr.com. While convenient, this needs an entry on our CSP to allow jsdelivr, which malicious actors might take advantage of. - Replace govtech-sgds with CSS specific to the masthead, and the Lion Head Symbol introduced earlier - Remove jsdelivr entries in CSP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The transition and 404 pages currently have a dependency on
govtech-sgds, delivered via cdn.jsdelivr.com. While convenient, this
needs an entry on our CSP to allow jsdelivr, which malicious actors
might take advantage of.
Solution
Lion Head Symbol introduced earlier