refactor(server-views): refactor public assets and styles for dynamic server views #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… server views Currently, our server view pages use static assets, which need to be converted to dynamic assets based on the `ASSET_VARIANT` env var. -reorganised public assets and styles -implemented dynamic loading of assets at render time -implemented toggling of mastheads for server views
LoneRifle
requested changes
Mar 16, 2021
There was a problem hiding this comment.
lgtm otherwise. take care when writing commit messages:
- subject line should be no more than 72 chars, 50 char limit generally preferable
- things done should be written in the imperative, so use present tense, not past
See Chris Beam's article for more information
…sets -updated the top level directories for assets, locales and index files -updated asset sources in server views, i18n and webpack
Co-authored-by: LoneRifle <LoneRifle@users.noreply.github.com>
-dynamically hide masthead for edu build base layout -updated instances of golink.edu.sg/edu.edu.sg to for.edu.sg
LoneRifle
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, our server view pages use static assets, which need to be converted to dynamic assets based on the
ASSET_VARIANTenv var.Part of work for #777
Solution