fix(url-validation): use error response from server #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the server createURL error handler defaults to printing the full error message in the logger and outputs 'Server Error' as the error message -replaced 'Server Error' with actual error message from server -changed blacklist url error message to match circular redirects error message (keep the 'error' in 'Validation error' lowercase) fix #1175
Currently, tests expect a string with no type -remove LongURLError type to match expected results fix #1175
orbitalsqwib
changed the title
LoneRifle
requested changes
Mar 16, 2021
…te tests for functionality
LoneRifle
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Server errors are currently hard-coded to display "Server Error", instead of the actual error response returned from the server.
Closes #1175
Solution
Fixed the error handling code to display the actual error message from the response.