Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(user-controller): added tests to cover create-url function error handling #1309

Merged
merged 1 commit into from
Mar 17, 2021
Merged

test(user-controller): added tests to cover create-url function error handling #1309

merged 1 commit into from
Mar 17, 2021

Conversation

orbitalsqwib
Copy link
Contributor

covers the error handling for NotFoundError, AlreadyExistsError and Sequelize.ValidationError functions in UserController.createUrl

@LoneRifle LoneRifle force-pushed the fix/url-validation branch from d98b959 to da007a4 Compare March 16, 2021 10:35
LoneRifle
LoneRifle approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LoneRifle LoneRifle merged commit 44f8ce3 into develop Mar 17, 2021
@LoneRifle LoneRifle deleted the fix/url-validation branch March 17, 2021 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoneRifle LoneRifle LoneRifle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orbitalsqwib @LoneRifle