Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(masthead): add default asset variant for masthead #1310

Merged
merged 2 commits into from
Mar 17, 2021
Merged

fix(masthead): add default asset variant for masthead #1310

merged 2 commits into from
Mar 17, 2021

Conversation

orbitalsqwib
Copy link
Contributor

Problem

Masthead does not show up if ASSET_VARIANT env var is not set

Solution

Added defaults to use 'gov' as default value for ASSET_VARIANT

LoneRifle
LoneRifle approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LoneRifle LoneRifle marked this pull request as ready for review March 17, 2021 04:00
@LoneRifle LoneRifle merged commit 46d3f59 into develop Mar 17, 2021
@LoneRifle LoneRifle deleted the fix/masthead branch March 18, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoneRifle LoneRifle LoneRifle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orbitalsqwib @LoneRifle