fix(qr-fonts): implement ibm plex sans for qrcode url #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added appropriate styles to qr generation in `QRCodeService` to render IBM Plex Sans Regular - added wget command in Dockerfile to install IBM Plex Sans Regular in the container instance to give sharp access to the font fix #433
LoneRifle
approved these changes
Mar 18, 2021
|
I see the following error when trying to spin up gitpod: |
Gitpod does not use `/usr/share/fonts/TTF` but rather `usr/share/fonts/truetype` for sourcing its fonts. I suspect this may be due to gitpod using a debian distro rather than alpine - switched to use truetype dir instead of TTF #fix 433
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the font used in qr-code generation does not sufficiently distinguish between (capital i)
I,1and (lowercase L)l.Closes #433
Solution
Implement IBM Plex Sans as the font for qr code generation instead of the default sans-serif font.
QRCodeServiceto render IBM Plex Sans Regularsharp access to the font
Screenshots
Before
After
Deploy Notes
Note that IBM Plex Sans is sourced from Google Fonts when exporting to SVG, while sharp uses a container-installed instance of the same font from IBM's Plex typeface repository (link).
As such, modifications have been made to the appropriate Dockerfiles to get the container instance to download the appropriate font and subsequently install via
fc-cache -f, which force rebuilds the font configurations on Alpine Linux.