Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(edu-pipeline) implement ci build pipeline for edu #1326

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

orbitalsqwib
Copy link
Contributor

@orbitalsqwib orbitalsqwib commented Mar 18, 2021

Problem

Currently, there is no pipeline for the edu variant of go.gov.sg to be built and deployed.

Part of work #777

Solution

  • Implemented build-edu and deploy-edu actions for continuous integration
  • Implemented build args for ASSET_VARIANT in Dockerfile so that production builds can inject the env var into the container properly

@orbitalsqwib orbitalsqwib requested a review from LoneRifle March 18, 2021 08:08
@orbitalsqwib orbitalsqwib changed the title Build/edu pipeline build(edu-pipeline) implement build pipeline for edu Mar 18, 2021
@orbitalsqwib orbitalsqwib changed the title build(edu-pipeline) implement build pipeline for edu build(edu-pipeline) implement ci build pipeline for edu Mar 18, 2021
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LoneRifle LoneRifle merged commit ba78250 into develop Mar 18, 2021
@LoneRifle LoneRifle deleted the build/edu-pipeline branch March 18, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants