refactor(redux-actions): refactor redux types to use generics #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented generic redux actions interfaces through intersection type extensions - Refactored redux type definitions to use generic interfaces fix #938
- Defined another type to save on the repetition of ampersands (DRY principle) - Refactored Redux actions to adopt other type when appropriate fix #938
orbitalsqwib
force-pushed
the
refactor/redux-actions
branch
from
12668ea to
3225d5c
Compare
LoneRifle
reviewed
Mar 24, 2021
yong-jie
reviewed
Mar 24, 2021
LoneRifle
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Duplicate boilerplate code exists where Redux actions are present. By addressing this issue, not only will we adhere to the DRY principle, but it will also help ensure that all Redux actions are typed correctly throughout the codebase.
Closes #938
Solution