refactor(babelrc): migrate babelrc to babel.config.json #1338
Conversation
orbitalsqwib
force-pushed
the
refactor/babelrc
branch
from
dae84cf to
23fe103
Compare
|
I've tested the latest commit with Chrome, Firefox, Safari and also verified that at minimum the transition and landing pages for IE 11 work properly (though the transition page has some styling issues that leave the background completely white). As such, I believe that the new config should be ready for merging as of the latest commit, though I may want to postpone the merge until the team can discuss whether they want to add the additional plugins for babel. |
|
You also need to test functionality, since this PR is modifying the JS transpilation process. |
|
As for functionality, I’ve done the end to end tests for the platforms specified in my previous comment with the exception of IE11, as there were some issues with the VM i was using |
It is good practice in Babel 7.x to use a project-wide babel.config.json instead of .babel.rc, which is a relic of Babel 6.x (we are on 7.x). - implemented babel.config.json based on FormSG's current configuration fix #1264
- Added corejs and regenerator-runtime dependencies for babel preset-env fix #1264
LoneRifle
force-pushed
the
refactor/babelrc
branch
from
23fe103 to
4a84998
Compare
|
snyk test errored out, not an actual failure |
LoneRifle
dismissed
liangyuanruo’s stale review
Functionality tested on IE11, all good
Problem
It is good practice in Babel 7.x to use a project-wide babel.config.json instead of .babel.rc, which
is a relic of Babel 6.x (we are on 7.x).
Closes #1264
Solution