Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): fix webpack for IE 11 support #1344

Merged
merged 1 commit into from
Mar 23, 2021
Merged

fix(webpack): fix webpack for IE 11 support #1344

merged 1 commit into from
Mar 23, 2021

Conversation

orbitalsqwib
Copy link
Contributor

Problem

Currently, webpack 5 builds to target es6 by default, which breaks IE 11 since it only supports up to es5. Additionally, webpack 5 drops quite a few polyfills, which triggers warnings to provide fallbacks even if unused. There is also a transpilation issue with react components where IE would break if the transpilation order was incorrect.

Solution

  • Changed webpack build target to es5
  • Added fallbacks for unused polyfills that webpack 5 drops from webpack 4
  • Specified transpilation order to fix an issue with IE, where it would break react components otherwise

Currently, webpack 5 builds to target es6 by default, which breaks IE 11 since it only supports up
to es5.

- Changed webpack build target to es5
- Added fallbacks for unused polyfills that webpack 5 drops from webpack 4
- Specified transpilation order to fix an issue with IE where it breaks react components otherwise
@orbitalsqwib orbitalsqwib requested a review from LoneRifle March 23, 2021 08:25
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LoneRifle LoneRifle merged commit cfa4f40 into develop Mar 23, 2021
@LoneRifle LoneRifle deleted the fix/webpack branch March 23, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants