feat(maildev): log OTP in console through maildev in dev mode #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- logs the OTP in console for logins through maildev during development mode for convenience - implements maildev support for gitpod
LoneRifle
reviewed
Mar 24, 2021
orbitalsqwib
force-pushed
the
feat/maildev
branch
3 times, most recently
from
63bff04 to
9bb6c0f
Compare
- Implemented code injection for the maildev executable to enable OTP logging on new mail - Modified the docker-run command to run a local instance of verbose maildev
orbitalsqwib
force-pushed
the
feat/maildev
branch
from
9bb6c0f to
f99f0de
Compare
- Refactored transport options to share `SES_HOST` and `SES_PORT` with maildev
orbitalsqwib
force-pushed
the
feat/maildev
branch
from
46d3351 to
dadc16c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the implementation for maildev does not include support for Gitpod, as maildev is run on another container instance and thus cannot be ported to Gitpod as is. Furthermore, the development workflow is slightly slowed down due to having to get the OTP manually from maildev's visual interface through
localhost:1080.Solution
By logging the OTP in the console, developers should be able to retrieve the OTP there and log into the application without having to open
localhost:1080. In addition, this pull request also implements maildev for Gitpod through running a maildev instance on the same container instance.Deploy Notes
Environmental Variables
SES_HOSTandSES_PORTfor configuring maildev host and smtp ports.docker-compose.ymlsetsSES_HOSTandSES_PORTtomaildevand25respectivelygitpod.DockerfilesetsSES_HOSTandSES_PORTtolocalhostand1025respectively