Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(assets): reskin frontend for for.edu.sg #1365

Merged
merged 11 commits into from
Apr 7, 2021
Merged

feat(assets): reskin frontend for for.edu.sg #1365

merged 11 commits into from
Apr 7, 2021

Conversation

LoneRifle
Copy link
Contributor

Problem

Closes #777

Solution

[assets and refactoring]

  • feat(qr): make edu QR codes black, measure logo to place in QR code
  • refactor(theme): parameterise colors to theme, add edu variant
  • chore(assets): change assets for for.edu.sg

[polish]

  • chore(docker-compose): set asset variant to gov
  • fix(text): parameterise officer types, email domain suffix
  • build(webpack): feed assetVariant into frontend, not the env var
  • fix(login): fill full window height if edu
  • chore(webpack): update metadata for edu

@LoneRifle
feat(qr): make edu QR codes black, measure logo to place in QR code
c922623 
- QR codes generated for for.edu.sg should be black
- Instead of assuming that logos are squares and 0.35 * QR code width,
  Actually parse the logo SVG and obtain its dimensions to figure out
  placement in QR code
@LoneRifle
refactor(theme): parameterise colors to theme, add edu variant
00c8d00
@LoneRifle
build(webpack): feed assetVariant into frontend, not the env var
2c499f0
@LoneRifle LoneRifle force-pushed the feat/edu/assets branch 3 times, most recently from eecc33f to 9cb5545 Compare April 5, 2021 02:43
@LoneRifle LoneRifle merged commit 6847d17 into develop Apr 7, 2021
@LoneRifle LoneRifle deleted the feat/edu/assets branch April 7, 2021 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbitalsqwib orbitalsqwib orbitalsqwib approved these changes

@liangyuanruo liangyuanruo Awaiting requested review from liangyuanruo

@lisa-kwok lisa-kwok Awaiting requested review from lisa-kwok

@pearlyong pearlyong Awaiting requested review from pearlyong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup for.edu.sg
2 participants
@LoneRifle @orbitalsqwib