Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(drawer): add empty link analytics graphic #1385

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

orbitalsqwib
Copy link
Contributor

Problem

There is no graphic to show when there are no link analytics

Closes [insert issue #]

Solution

How did you solve the problem?

Features:

  • Adds graphic assets for empty link analytics
  • Updated the link drawer control panel code to show the graphics when there are no link analytics

Before & After Screenshots

BEFORE
Go.gov.sg
Screenshot 2021-04-08 at 5 13 47 PM

For.edu.sg
Screenshot 2021-04-08 at 5 14 04 PM

AFTER:
Go.gov.sg
Screenshot 2021-04-08 at 4 54 53 PM

For.edu.sg
Screenshot 2021-04-08 at 4 57 44 PM

Tests

  • Create a new link on both edu and for, then click into the link drawer control panel
  • Check that the graphics show up on both edu as above in the screenshots

@orbitalsqwib orbitalsqwib requested a review from LoneRifle April 8, 2021 09:14
@orbitalsqwib orbitalsqwib merged commit ce0e01a into develop Apr 8, 2021
@orbitalsqwib orbitalsqwib deleted the feat/empty-link-analytics-graphics branch April 8, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants