-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mergify): automatically merge bot dependency upgrades #1420
Conversation
I had a think about this - I want to try to dump all the dependabot-related commits into its own branch, so mergify should be directed to accommodate that too. Given that there is other work that goes on in With that in place, we can squash and merge dependency updates just once per release cycle, prior to pre-release testing. This gives us the automation from mergify while also keeping commit log noise to a minimum. wdyt? |
This PR instructs the mergify bot to automatically merge pull requests from 1. dependabot 2. Snyk.io Pull requests are automatically merged if 1. The proposed upgrade is a non-major version change 2. All existing CI checks pass Closes #1418
ed86788
to
a612aaf
Compare
@LoneRifle don't merge yet, testing rule validity |
ok it should be good to go |
as per Forms, we can actually rely on branch protections to ensure that PRs don't get merged unless all CI checks pass, rather than having to keep the mergify config in sync with the CI steps |
Although you're right that it won't affect this repository, it's possible that someone cloning the repository will not configure their branch protections properly. Usually explicit is better than implicit, and we should also avoid relying on side effects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eh, lgtm.
@liangyuanruo okay, but tbh sounds like a lot of work just to optimise for a hypothetical person cloning the repo |
This PR instructs the mergify bot to automatically merge pull requests from
Pull requests are automatically merged if
Closes #1418