Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(login-form): add referral to for.edu.sg #1429

Merged
merged 3 commits into from
May 5, 2021
Merged

feat(login-form): add referral to for.edu.sg #1429

merged 3 commits into from
May 5, 2021

Conversation

orbitalsqwib
Copy link
Contributor

Problem

Add a quick liner on go.gov.sg to refer edu users to for.edu.sg.

Closes #1428

Solution

Features:

  • Modify login form to refer school staff with .edu.sg emails to for.edu.sg

Screenshots

Screenshot 2021-05-04 at 4 17 40 PM

Tests

  • Check that clicking on for.edu.sg redirects the user to for.edu.sg

@orbitalsqwib orbitalsqwib requested a review from LoneRifle May 4, 2021 08:23
LoneRifle
LoneRifle requested changes May 4, 2021
View reviewed changes
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do a more involved change involving i18next ya

@orbitalsqwib
feat(login-form): implement referral line for both builds
a345b17 
- shift referral line to below login header
- style referral line to keep login header as main focus
- implement referral line for both edu and for builds
LoneRifle
LoneRifle approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this for now. the line referring officers to somewhere else should be more flexible; we might have to deal with more sectors in future, so just having one placeholder value rather than three in a rigid structure would have been preferred.

@orbitalsqwib orbitalsqwib merged commit 0b16245 into develop May 5, 2021
@orbitalsqwib orbitalsqwib deleted the feat/add-referral-to-login branch May 5, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoneRifle LoneRifle LoneRifle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add for.edu.sg on gogovsg log in page.
2 participants
@orbitalsqwib @LoneRifle