Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/privacy: remove exposure of long URLs from GoDirectory #1480

Merged
merged 4 commits into from
May 18, 2021

Conversation

liangyuanruo
Copy link
Contributor

Problem

Exposing the long URL on GoDirectory may reveal sensitive URLs if users are not savvy.

Solution

Remove the long URL from both the UI and the /search API.

Improvements:

  • Users cannot use GoDirectory to mine links for inactive links

Screenshots

image

@liangyuanruo liangyuanruo requested a review from yong-jie May 18, 2021 11:14
Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yong-jie yong-jie merged commit f2c3af1 into develop May 18, 2021
@yong-jie yong-jie deleted the fix/privacy branch May 18, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants