Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/warning: Warn users that their links will be indexable by search engines #1481

Merged
merged 2 commits into from
May 19, 2021

Conversation

liangyuanruo
Copy link
Contributor

Problem

Users may upload sensitive content that ends up being discovered by other users on the directory, or indexed by search engines.

Solution

Add a suitable message to the creation modal for both link and file creation, that has been endorsed by @lisatjide .

Improvements:

  • Users should (hopefully!) think twice about making sensitive documents public.

Screenshots

LInk creation
image

File creation
image

@liangyuanruo liangyuanruo requested a review from lisa-kwok May 18, 2021 13:05
Copy link

@lisa-kwok lisa-kwok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@liangyuanruo liangyuanruo merged commit 1d166f3 into develop May 19, 2021
@liangyuanruo liangyuanruo deleted the feat/warning branch May 19, 2021 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants