Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front-end implementation for editing file links #153

Merged
merged 7 commits into from
Jun 9, 2020
Merged

Conversation

JasonChong96
Copy link
Contributor

Problem

Users might want to replace their uploaded files. This PR implements the front-end for replacing files.

Solution

Improvements:

  • Fixed margins on url drawer
  • Fixed url drawer button border colors
  • Extend CollapsibleMessage to be able to be absolute positioned if needed

Before & After Screenshots

AFTER:
Desktop
iPhone X

Tests

  1. Replace file with same extension, it should be replaced with the new file
  2. Replace file with different extension, long url should change to reflect new extension. Old file should be set to private and new file should be accessible

yong-jie
yong-jie previously approved these changes Jun 8, 2020
Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is lgtm

Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked through the code, lgtm.

@yong-jie yong-jie changed the title Front-end implementation for editting file links Front-end implementation for editing file links Jun 9, 2020
@JasonChong96 JasonChong96 merged commit 3f0a64e into develop Jun 9, 2020
@JasonChong96 JasonChong96 deleted the edit-files branch June 9, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants