Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for logout middleware #154

Merged
merged 3 commits into from
Jun 8, 2020
Merged

Add unit tests for logout middleware #154

merged 3 commits into from
Jun 8, 2020

Conversation

JasonChong96
Copy link
Contributor

Problem

Logout middleware has no unit tests

[Closes #85]

Solution

Refactor logout middleware to be seperated into the routes and handler functions so that handlers can be unit tested. Add unit tests for handlers.

@liangyuanruo liangyuanruo merged commit 3f3fa51 into develop Jun 8, 2020
@liangyuanruo liangyuanruo deleted the logout-api-tests branch June 8, 2020 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangyuanruo liangyuanruo liangyuanruo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce unit tests for logout middleware
2 participants
@JasonChong96 @liangyuanruo